Conversation
|
Preview this PR here: https://dev-docs.revenuecat.com/pr-1313/ |
polmiro
approved these changes
Jan 13, 2026
| @@ -0,0 +1,50 @@ | |||
| --- | |||
| title: Ad Impressions Chart | |||
Member
There was a problem hiding this comment.
Note
This applies to all the charts
We removed the Ad prefix prefix for all ads charts in the Dashboard since it felt redundant. This title is also used in the sidebar where the redundancy is obvious. For consistency I would suggest removing it here as well. Not a strong opinion by any means.
polmiro
reviewed
Jan 13, 2026
…f the language, and add in some details about Ad Format
Collaborator
Author
|
FYI @peterporfy added a little about ad format now that you've added support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Description / Changes introduced
This PR adds all the necessary documentation supporting the new ads charts we're introducing as part of the ads tracking feature.